Skip to content

fix: format else statements #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2025
Merged

fix: format else statements #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions shorten/format.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,10 @@ func (s *Shortener) formatStmt(stmt dst.Stmt, force bool) {
s.formatStmt(st.Init, shouldShorten)
}

if st.Else != nil {
s.formatStmt(st.Else, shouldShorten)
}

case *dst.RangeStmt:
s.formatStmt(st.Body, false)

Expand Down
18 changes: 17 additions & 1 deletion shorten/testdata/conditionals/conditionals.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,24 @@ package fixtures

import "fmt"

func testFunc3() {
func _() {
if "hello this is a big string" == "this is a small string" && "this is another big string" == "this is an even bigger string >>>" {
fmt.Print("inside if statement")
}
}

func _() {
if "hello this is a big string" == "this is a small string" && "this is another big string" == "this is an even bigger string >>>" {
fmt.Print("Lorem ipsum dolor sit amet deserunt. Commodo duis Lorem pariatur quis labore non quis aliquip.")
} else {
fmt.Print("Lorem ipsum dolor sit amet deserunt. Commodo duis Lorem pariatur quis labore non quis aliquip.")
}
}

func _() {
if "hello this is a big string" == "this is a small string" && "this is another big string" == "this is an even bigger string >>>" {
fmt.Print("Lorem ipsum dolor sit amet deserunt. Commodo duis Lorem pariatur quis labore non quis aliquip.")
} else if "hello this is a big string 1" == "this is a small string" && "this is another big string 2" == "this is an even bigger string >>>" {
fmt.Print("Lorem ipsum dolor sit amet deserunt. Commodo duis Lorem pariatur quis labore non quis aliquip.")
}
}
29 changes: 28 additions & 1 deletion shorten/testdata/conditionals/conditionals.go.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,36 @@ package fixtures

import "fmt"

func testFunc3() {
func _() {
if "hello this is a big string" == "this is a small string" &&
"this is another big string" == "this is an even bigger string >>>" {
fmt.Print("inside if statement")
}
}

func _() {
if "hello this is a big string" == "this is a small string" &&
"this is another big string" == "this is an even bigger string >>>" {
fmt.Print(
"Lorem ipsum dolor sit amet deserunt. Commodo duis Lorem pariatur quis labore non quis aliquip.",
)
} else {
fmt.Print(
"Lorem ipsum dolor sit amet deserunt. Commodo duis Lorem pariatur quis labore non quis aliquip.",
)
}
}

func _() {
if "hello this is a big string" == "this is a small string" &&
"this is another big string" == "this is an even bigger string >>>" {
fmt.Print(
"Lorem ipsum dolor sit amet deserunt. Commodo duis Lorem pariatur quis labore non quis aliquip.",
)
} else if "hello this is a big string 1" == "this is a small string" &&
"this is another big string 2" == "this is an even bigger string >>>" {
fmt.Print(
"Lorem ipsum dolor sit amet deserunt. Commodo duis Lorem pariatur quis labore non quis aliquip.",
)
}
}
Loading