Migrate DropdownViewHolderFactory to compose #2898
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LZRS
force-pushed
the
sdc-compose-dropdown
branch
5 times, most recently
from
2e9773f to
6f0ce2c
Compare
LZRS
force-pushed
the
sdc-compose-dropdown
branch
from
6f0ce2c to
da3a8b7
Compare
jingtang10
approved these changes
Nov 6, 2025
Collaborator
There was a problem hiding this comment.
Laz said this is actually an instrumentation test - in that case the file needs to be renamed.
if this is a problem with other compose tests we need to rename those test files too.
github-project-automation
bot
moved this from New
to PR under Review
in Android FHIR SDK
Collaborator
Author
|
Before Screen_recording_20251111_001344.mp4After Screen_recording_20251111_011254.mp4 |
jingtang10
approved these changes
Nov 26, 2025
| remember(selectedOption, options) { mutableStateOf(selectedOption) } | ||
|
|
||
| // Track if change is from user typing | ||
| var isUserTyping by remember(options) { mutableStateOf(false) } |
Collaborator
There was a problem hiding this comment.
this is not for when the user is actively typing.. this is true after the user started typing but have not made any selections.
add a small comment to explain this.
also maybe call this "in filter mode"? i'll leave it to you to decide what's the best name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #2861
Description
Clear and concise code change description.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.