Skip to content

Fix answers disappearing from edit text on scrolling down #2921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix answers disappearing from edit text on scrolling down #2921

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions ...ture/src/main/java/com/google/android/fhir/datacapture/views/compose/EditTextFieldItem.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.OutlinedTextField
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
import androidx.compose.runtime.LaunchedEffect
import androidx.compose.runtime.getValue
import androidx.compose.runtime.mutableStateOf
import androidx.compose.runtime.remember
Expand Down Expand Up @@ -86,12 +85,10 @@ internal fun OutlinedEditTextFieldItem(
}
var isFocused by remember { mutableStateOf(false) }

// Update the local state when the initial inputText changes and the field is not focused
LaunchedEffect(inputText) {
if (!isFocused && textFieldValue.text != inputText) {
textFieldValue =
textFieldValue.copy(text = inputText, selection = TextRange(inputText.length))
}
// Synchronize local state when inputText changes from external source (e.g., view recycling)
// This runs synchronously before the first frame is rendered, ensuring correct display
if (!isFocused && textFieldValue.text != inputText) {
textFieldValue = TextFieldValue(text = inputText, selection = TextRange(inputText.length))
}

OutlinedTextField(
Expand Down
Loading