Refactor ffi_11 crate to use newtypes. #57
+288
−129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously when we could be confident a C++ and Rust type matched in bit width, it would be a type alias in ffi_11. Relying on aliases is problematic for the rmeta interface (aliases don't exist at the MIR level). Instead, use wrapper structs so our ffi types are considered distinct at the MIR level. PiperOrigin-RevId: 830498336
copybara-service
bot
force-pushed
the
test_830498336
branch
from
a3c1656 to
1816347
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor ffi_11 crate to use newtypes.
Previously when we could be confident a C++ and Rust type matched in bit
width, it would be a type alias in ffi_11. Relying on aliases is
problematic for the rmeta interface (aliases don't exist at the MIR
level). Instead, use wrapper structs so our ffi types are considered
distinct at the MIR level.