Add missing bounds check in RAnsDecoder::read_init#1192
Open
TristanInSec wants to merge 1 commit intogoogle:mainfrom
Open
Add missing bounds check in RAnsDecoder::read_init#1192TristanInSec wants to merge 1 commit intogoogle:mainfrom
TristanInSec wants to merge 1 commit intogoogle:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
The x==3 branch reads 4 bytes via mem_get_le32 but does not validate that offset >= 4 before computing buf + offset - 4. The other branches (x==1, x==2) already have their respective guards. Add the missing check to return an error when the buffer is too small.
TristanInSec
force-pushed
the
fix-rans-read-init-bounds
branch
from
bbe8d5e to
da3003f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
offset < 4guard to thex == 3branch inRAnsDecoder::read_init()x == 1,x == 2) already validate their respective minimum offsets before readingTest plan
ans_read_initC function