Require -XDaddTypeAnnotationsToSymbol=true, and remove workaround for JDK-8225377
#5427
+94
−514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_852278227
branch
3 times, most recently
from
45d9219 to
7f0f72f
Compare
…or JDK-8225377 This removes workarounds for https://bugs.openjdk.org/browse/JDK-8225377, which is fixed in JDK 21.0.8 and newer releases if `-XDaddTypeAnnotationsToSymbol=true` is enabled. #5426 Startblock: * unknown commit is submitted RELNOTES=The javac flag `-XDaddTypeAnnotationsToSymbol=true` is now required for Error Prone invocations on JDK 21, to enable the javac fix for JDK-8225377 (type annotations are not visible to javac plugins across compilation boundaries). See #5426 for details. PiperOrigin-RevId: 853255760
copybara-service
bot
force-pushed
the
test_852278227
branch
from
7f0f72f to
5b768ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require
-XDaddTypeAnnotationsToSymbol=true, and remove workaround for JDK-8225377This removes workarounds for https://bugs.openjdk.org/browse/JDK-8225377, which is fixed in JDK 21.0.8 and newer releases if
-XDaddTypeAnnotationsToSymbol=trueis enabled.#5426
Startblock:
RELNOTES=The javac flag
-XDaddTypeAnnotationsToSymbol=trueis now required for Error Prone invocations on JDK 21, to enable the javac fix for JDK-8225377 (type annotations are not visible to javac plugins across compilation boundaries). See Require the javac flag -XDaddTypeAnnotationsToSymbol=true for Error Prone invocations #5426 for details.