Skip to content

Add __eq__ for variables #5084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2025
+6 −0
Merged

Add __eq__ for variables #5084

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions flax/nnx/variablelib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -777,6 +777,11 @@ def __ror__(self, other) -> A:
other = other.value
return self.value.__ror__(other) # type: ignore

def __eq__(self, other) -> bool:
if isinstance(other, Variable):
other = other.value
return self.value.__eq__(other) # type: ignore

def __iadd__(self: V, other) -> V:
raise NotImplementedError(
'In-place operations are no longer supported for Variable.\n'
Expand Down
1 change: 1 addition & 0 deletions tests/nnx/variable_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ def test_binary_ops(self):
result = v1 + v2

self.assertEqual(result, 5)
self.assertFalse(v1 == v2)

v1[...] += v2

Expand Down
Loading