query: honor Encoder on interface fields#187
Merged
Merged
Conversation
reflectValue checked sv.Type().Implements(encoderType) against the static
field type, so a value stored in an interface{} field never used its
EncodeValues method and fell back to default formatting. Unwrap the interface
first so the concrete type's Encoder is seen.
Fixes google#121
Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
willnorris
approved these changes
Jul 6, 2026
Collaborator
|
looks good to me, thanks! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #187 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 165 140 -25
=========================================
- Hits 165 140 -25 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reflectValuecheckssv.Type().Implements(encoderType)on the static field type. When a field is declared asinterface{}, that type is the empty interface, which doesn't implementEncoder, so a value stored there never gets itsEncodeValuesmethod called and falls back to default formatting (e.g.v=[a b]instead ofv.0=a&v.1=b).Unwrapping the interface to its concrete value before the check fixes it, and lets the value be formatted by its dynamic type in general. Added an
interface{}-field case toTestValues_CustomEncodingSlice; it producedv=[a b]before the change.Fixes #121