Consolidate clean, lint and test into authoritative commands

[rfontanarosa]

towards #2341

[gemini-code-assist]

Summary of Changes

Hello @rfontanarosa, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the project's development workflow by refactoring the execution of common tasks like cleaning, linting, and testing. By migrating these operations to Nx targets, the project benefits from a more consistent and integrated approach to task management within the monorepo. The changes also include updates to how Nx discovers ESLint configurations and specific adjustments to ESLint rules to provide more flexibility in type usage and variable handling.

Highlights

• Command Consolidation: The clean, lint, and test commands have been moved from root package.json scripts to dedicated Nx targets, centralizing their execution logic within the monorepo configuration.
• Nx Configuration Update: The nx.json file has been updated to enhance ESLint configuration file discovery, now supporting eslint.base.config.{js,mjs,cjs} and eslint.config.{js,mjs,cjs} across the workspace and individual projects.
• ESLint Rule Adjustments: The @typescript-eslint/no-explicit-any rule has been disabled in both functions/eslint.config.mjs and web/eslint.config.mjs. Additionally, the web project's ESLint configuration now ignores unused caught error variables prefixed with an underscore (_) in the @typescript-eslint/no-unused-vars rule.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request consolidates the clean, lint, and test scripts into authoritative Nx commands at the root level, which is a good improvement for managing the monorepo. The changes in nx.json and package.json correctly implement this. However, the pull request also disables the @typescript-eslint/no-explicit-any rule in both the functions and web projects. This is a significant concern as it compromises TypeScript's type safety, potentially hiding bugs and making the code harder to maintain. I've added comments to both ESLint configuration files recommending that this rule be re-enabled as a warning.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.34%. Comparing base (f48c05a) to head (e8e2853).

Files with missing lines	Patch %	Lines
web/src/testing/helpers.ts	25.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2405      +/-   ##
==========================================
- Coverage   59.35%   59.34%   -0.02%     
==========================================
  Files         115      115              
  Lines        2869     2868       -1     
  Branches      427      427              
==========================================
- Hits         1703     1702       -1     
  Misses       1106     1106              
  Partials       60       60              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[gino-m]

👍