refactor(Joiner): rename internal toString helper to toCharSequence#8519
Open
Derylfabiensyah wants to merge 2 commits into
Open
refactor(Joiner): rename internal toString helper to toCharSequence#8519Derylfabiensyah wants to merge 2 commits into
Derylfabiensyah wants to merge 2 commits into
Conversation
ricardoofnl
reviewed
Jul 2, 2026
ricardoofnl
left a comment
ricardoofnl
left a comment
There was a problem hiding this comment.
Nice mechanical rename. I checked all call sites in both trees and nothing was missed. There is one small leftover, which I flagged inline in both files.
|
|
||
| // TODO(cpovirk): Rename to "toCharSequence." | ||
| CharSequence toString(@Nullable Object part) { | ||
| CharSequence toCharSequence(@Nullable Object part) { |
There was a problem hiding this comment.
The comment block further down in this method (around line 524) still references the old name:
Its implementation avoids calling this
toString(Object)method in the first place.
Since this PR renames the method, it would be good to update that mention to toCharSequence(Object) as well.
|
|
||
| // TODO(cpovirk): Rename to "toCharSequence." | ||
| CharSequence toString(@Nullable Object part) { | ||
| CharSequence toCharSequence(@Nullable Object part) { |
There was a problem hiding this comment.
Same as in the JRE flavor: the comment block further down in this method (around line 488) still says toString(Object) and should be updated to toCharSequence(Object) as part of this rename.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renamed the package-private helper method
toString(Object)totoCharSequence(Object)inJoiner.javato resolve cpovirk's TODO.This clarifies the return type (
CharSequence) and avoids shadowing the standardObject.toString()signature for internal calls. Both the standard and Android version source trees have been updated.