refactor: Simplify some conditional logic to remove unreachable branches. #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hes.
```
if !lineRange.empty() {
finishGroup()
}
```
guarantees that `lineRange.empty()` will be true after it (`finishGroup`
zeroes out `lineRange`). That lets us get rid of one of the branches in
the `metadata.opts.Group` conditional. But now the remaining branch
shares a lot in common with the `else` branch, so we can simplify a bit
further.
KatrinaHoffert
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
guarantees that
lineRange.empty()will be true after it (finishGroupzeroes outlineRange). That lets us get rid of one of the branches in themetadata.opts.Groupconditional. But now the remaining branch shares a lot in common with theelsebranch, so we can simplify a bit further.