Add android_jank_cujs table to stdlib. #3458
Open
+78
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of the stdlib migration, we plan to move the android_jank_cuj table to stdlib. As a first step, move the generic tables to a separate module, which will contain CUJ jank information for all relevant processes. Bug: 456326892 Test: tools/diff_test_trace_processor.py --keep-input --name-filter ".*sysui_jank_cujs.*" out/linux_clang_debug/trace_processor_shell
This table is a stdlib version of the android_jank_cuj table present at src/trace_processor/metrics/sql/android/jank/cujs.sql This table will read CUJ slices from a common place, to keep the cuj_id logic unified. Bug: 456326892
LalitMaganti
approved these changes
Oct 30, 2025
elrakadm
reviewed
Oct 31, 2025
| ) AS | ||
| SELECT | ||
| cuj.*, | ||
| _extract_cuj_name_from_slice(cuj.cuj_slice_name) AS cuj_name, |
Member
There was a problem hiding this comment.
I think this function should be part of the base module, and not in sysu_cujs modules as this will be a circular dependency ?
Contributor
Author
There was a problem hiding this comment.
It is in the base module. It was moved here in this PR:
#3457
elrakadm
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This table is a stdlib version of the android_jank_cuj table present at
src/trace_processor/metrics/sql/android/jank/cujs.sql
This table will read CUJ slices from a common place, to keep the cuj_id
logic unified.
Bug: 456326892