Disable cpuinfo on Windows ARM64 - #377
Closed
ssss141414 wants to merge 1 commit into
Closed
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
ssss141414
force-pushed
the
windows-arm64-no-cpuinfo
branch
from
August 21, 2026 10:10
3cf5913 to
1541381
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cpuinfointegration when targeting native Windows ARM64Why
The vendored
cpuinfoconfiguration reports that WindowsARM64is unsupported and omits the ARM ISA data symbol, while Ruy still definesRUY_HAVE_CPUINFO. Linking an ARM64 consumer then fails with:ruy_cpuinfo.lib(cpuinfo.obj): error LNK2019: unresolved external symbol cpuinfo_isa referenced in ruy::CpuInfo::NeonDotprod()Ruy already supports builds without cpuinfo on other platforms. This change limits that existing fallback to Windows ARM64 and leaves all other targets unchanged.
Validation
Validated in a native Windows ARM64 CTranslate2 build using Ruy: the dependency links successfully, INT8 multithreaded inference returns the expected output, and the resulting DLL is native ARM64.