Conversation
src/src/index.html
Outdated
|
|
||
| <!-- By adding the 'inline' attribute, the build process will inline | ||
| this CSS file to improve load time performance--> | ||
| <link rel="stylesheet" href="/styles/index.css" type="text/css" inline> |
There was a problem hiding this comment.
To be 100% compliant, should we use data-inline? Or is inline an official attribute?
There was a problem hiding this comment.
We can customise the attribute, so data-inline sounds like a great idea tbh
|
Only one minor nit and I am not even sure we can do anything about that. Also tests. |
|
The auto-inlining clashes with work in PR #823 from another contributor. Maybe merge that in and then do an upgrade to the implementation? |
|
@Garbee This branch is a completely new tree (orphan). No clashing will ever happen :) |
|
oh, just noticed going into a 2.x branch. Yea nvm then. |
|
BUT . . . . . @Garbee thanks for bringing it to me attention - was a great feature to add in. |
|
@surma happy with the current state? I'm seeing some flakiness on the html watch task - will have to keep an eye on it. |
4 participants
This adds a task to manage html pages in the build process.
Major thing this does is:
Things this doesn't currently do (and not sure if we want to do this) - minify / optimise inline styles and javascript.
@addyosmani @surma + anyone else who has any ideas for improving this / anything we might be missing.