test(ffi): adopt Chromium invalid EC key vectors#314
Open
harrshita123 wants to merge 2 commits into
Open
Conversation
Pin Chromium's malformed EC key corpus and license to a reproducible revision. Add an update script that downloads the source files atomically.
Load the pinned malformed EC key corpus from disk and verify that native ECDSA JWK, SPKI, and PKCS8 imports reject every vector with a FormatException.
harrshita123
force-pushed
the
test/chromium-bad-ec-vectors
branch
from
9b2ce4c to
fca0171
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses part of #54.
Summary
bad_ec_keys.jsoncorpus and license at a pinned revision.The test reads the vectors from
third_party/chromium/at runtime and keeps the upstream file unchanged, including its comment-only lines. It checks that native ECDSA imports reject each malformed key with aFormatExceptionwithout depending on Chromium's exact error text.Browser execution is intentionally left for a follow-up, as discussed in #54.
Testing
dart format --output none --set-exit-if-changed .dart analyze --fatal-warnings .dart test test/ffi/chromium_bad_ec_keys_test.dartdart test --exclude-tags browser-interop -p vm,chrome -c dart2js,dart2wasm