Conversation
| } | ||
|
|
||
| @Test | ||
| public void create_withUnknownAdId_returnsConsistentView() { |
There was a problem hiding this comment.
Is debug mode enabled during unit tests? If yes, this may not be testing the new code you added, right?
There was a problem hiding this comment.
Ah! You are completely right! Unit tests run against the debug build variant so EmptyPlatformView wasn't being directly tested.
I've made EmptyPlatformView package-private and added a dedicated unit test to directly verify that EmptyPlatformView consistently returns the same View reference across getView() calls.
There was a problem hiding this comment.
Thank you for making the change.
The test names sound misleading in the case of null args, unknown Ad ID and null platform view. The intention is to return an empty view, right? I think you can replace "ConsistentView" with "EmptyView".
| } | ||
|
|
||
| @Test | ||
| public void create_withUnknownAdId_returnsConsistentView() { |
There was a problem hiding this comment.
Thank you for making the change.
The test names sound misleading in the case of null args, unknown Ad ID and null platform view. The intention is to return an empty view, right? I think you can replace "ConsistentView" with "EmptyView".
3 participants
Description
Fix Android platform view resize error when ErrorView is displayed in release mode for Android builds.
Related Issues
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?