fix: Avoid passing null as an array offset for longRunning descriptors in resumeOperation#842
Open
cy-yun wants to merge 4 commits into
Open
fix: Avoid passing null as an array offset for longRunning descriptors in resumeOperation#842cy-yun wants to merge 4 commits into
cy-yun wants to merge 4 commits into
Conversation
…s in resumeOperation This fixes a PHP 8.1 deprecation warning generated by the client libraries.
The @com_google_googleapis dependency updated the Spanner target from spanner_database_admin_proto to database_proto, which was failing the analysis phase of Bazel tests on GitHub Actions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: fix: Avoid passing null as an array offset for longRunning descriptors in resumeOperation
Description:
This PR fixes a PHP 8.1 deprecation warning generated by the client libraries when calling
resumeOperation().Previously,
resumeOperation($operationName, $methodName = null)passed$methodNamedirectly as an array offset when checking forlongRunningdescriptors, triggering a deprecation warning if$methodNamewasnull. The code generator has been updated to safely useisset($methodName)before attempting to access the array key.This improves the Spanner System Test by eliminating deprecation message spamming in the test outputs.
Fixes googleapis/google-cloud-php#9230