Open
Conversation
| $response = $httpHandler($request); | ||
| return json_decode((string) $response->getBody(), true); | ||
| } catch (ClientException $e) { | ||
| // We swallow all errors here - a failed trust boundary lookup |
Contributor
There was a problem hiding this comment.
It makes sense that we do not thrown, but it is weird to me having a catch without any code in it haha.
Contributor
Author
There was a problem hiding this comment.
What kind of code would you like to see here? Maybe some logging?
bshaffer
added
the
do not merge
Contributor
Author
|
This is currently blocked by the backend service |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b/480120031
Credential Support
Implementation
Features which require work in GAX
Optional features (to be evaluated)
Manual override seeding(will not implement)Testing