Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers a crucial tool for Python developers working with Google Cloud Spanner: an in-memory mock server. This server facilitates local development and testing by mimicking the behavior of a real Spanner instance, allowing for faster feedback cycles and more robust automated tests. It abstracts away the complexities of interacting with a live service, making it easier to simulate various scenarios and edge cases during development. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new google-cloud-spanner-mockserver package, which is a great addition for testing applications that use Spanner. The overall structure, including the use of nox for automation, packaging setup, and the test base class, is well-designed. However, the mock server implementation is currently partial, with several key gRPC methods implemented as placeholders. My review focuses on suggestions to complete these placeholder implementations to make the mock server more comprehensive and useful. I've also identified a critical issue in a generated gRPC client stub that uses incorrect serialization methods, which would cause runtime failures.
packages/google-cloud-spanner-mockserver/spannermockserver/generated/spanner_pb2_grpc.py
Show resolved
Hide resolved
packages/google-cloud-spanner-mockserver/spannermockserver/mock_spanner.py
Outdated
Show resolved
Hide resolved
packages/google-cloud-spanner-mockserver/spannermockserver/mock_spanner.py
Outdated
Show resolved
Hide resolved
packages/google-cloud-spanner-mockserver/spannermockserver/mock_spanner.py
Show resolved
Hide resolved
packages/google-cloud-spanner-mockserver/spannermockserver/mock_spanner.py
Show resolved
Hide resolved
packages/google-cloud-spanner-mockserver/spannermockserver/mock_spanner.py
Show resolved
Hide resolved
…n in-memory mock Spanner server for testing.
…ing to the noxfile.
…n, and update noxfile.
…deps` nox session for testing, and refine standard test dependencies.
…saction rollback to mock Spanner.
Add Spanner Mock Server to Python Monorepo.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes#16040 🦕