Skip to content

ci(bigquery-storage): fix core_deps_from_source and prerelease_deps by installing extras - #17529

Merged
ohmayr merged 1 commit into
mainfrom
fix-bigquery-storage-nox-sessions
Jun 22, 2026
Merged

ci(bigquery-storage): fix core_deps_from_source and prerelease_deps by installing extras#17529
ohmayr merged 1 commit into
mainfrom
fix-bigquery-storage-nox-sessions

Conversation

@ohmayr

@ohmayr ohmayr commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the dependency installation in packages/google-cloud-bigquery-storage/noxfile.py and its post-processing configuration to include unit test extras. It also changes the NOX_SESSION in .kokoro/presubmit/system.cfg to core_deps_from_source. Feedback indicates that changing NOX_SESSION in system.cfg to core_deps_from_source will incorrectly cause the system test presubmit job to run unit tests instead of system tests, and recommends using a unit test presubmit configuration instead.

Comment thread .kokoro/presubmit/system.cfg Outdated
@ohmayr ohmayr changed the title Fix bigquery storage nox sessions ci(bigquery-storage): fix core_deps_from_source and prerelease_deps by installing extras Jun 22, 2026
@ohmayr
ohmayr marked this pull request as ready for review June 22, 2026 19:54
@ohmayr
ohmayr requested review from a team as code owners June 22, 2026 19:54
@ohmayr
ohmayr requested review from GarrettWu and removed request for a team June 22, 2026 19:54
@ohmayr
ohmayr force-pushed the fix-bigquery-storage-nox-sessions branch from 00b38fd to ae88326 Compare June 22, 2026 20:13
@ohmayr
ohmayr merged commit 172302b into main Jun 22, 2026
32 checks passed
@ohmayr
ohmayr deleted the fix-bigquery-storage-nox-sessions branch June 22, 2026 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bigquery-storage: core_deps_from_source fails due to missing UNIT_TEST_EXTRAS

2 participants