ci(bigquery-storage): fix core_deps_from_source and prerelease_deps by installing extras - #17529
Merged
Merged
Conversation
…ce and prerelease_deps
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the dependency installation in packages/google-cloud-bigquery-storage/noxfile.py and its post-processing configuration to include unit test extras. It also changes the NOX_SESSION in .kokoro/presubmit/system.cfg to core_deps_from_source. Feedback indicates that changing NOX_SESSION in system.cfg to core_deps_from_source will incorrectly cause the system test presubmit job to run unit tests instead of system tests, and recommends using a unit test presubmit configuration instead.
core_deps_from_source and prerelease_deps by installing extras
ohmayr
marked this pull request as ready for review
June 22, 2026 19:54
ohmayr
force-pushed
the
fix-bigquery-storage-nox-sessions
branch
from
June 22, 2026 20:13
00b38fd to
ae88326
Compare
parthea
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #17530
Log: https://btx.cloud.google.com/invocations/bf99245e-a50a-4863-941e-a29163224a9d/targets/cloud-devrel%2Fclient-libraries%2Fpython%2Fgoogleapis%2Fgoogle-cloud-python%2Fpresubmit%2Fsystem/log