Skip to content

tests(bigtable): System/compatibility tests for testing shim compatiblity #17901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
daniel-sanche wants to merge 4 commits into
base: main
Choose a base branch
from
+844 −4
Draft

tests(bigtable): System/compatibility tests for testing shim compatiblity #17901

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
218779c
tests: System/compatibility tests for testing shim compatiblity (#1218)
gkevinzheng Nov 20, 2025
0315354
fixed lint
daniel-sanche Jul 29, 2026
fc463e7
added tolerance for system test
daniel-sanche Jul 29, 2026
730ff75
Merge branch 'main' into shim/01-compat-tests
daniel-sanche Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/google-cloud-bigtable/google/cloud/bigtable/row_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ def _on_error(self, exc):
retry_request = self._create_retry_request()

self._row_merger = _RowMerger(self._row_merger.last_seen_row_key)
self.response_iterator = self.read_method(retry_request)
self.response_iterator = self.read_method(retry_request, retry=self.retry)

@mutianf mutianf Aug 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's in self.retry? do we need to update attempt number or backoff time in it?


def _read_next(self):
"""Helper for :meth:`__iter__`."""
Expand Down
Loading
Loading