docs: correct return type in CellDataParser.time_to_py docstring - #17972
Open
fixedbydev wants to merge 1 commit into
Open
docs: correct return type in CellDataParser.time_to_py docstring#17972fixedbydev wants to merge 1 commit into
fixedbydev wants to merge 1 commit into
Conversation
time_to_py returns a datetime.time, but its docstring was copied from date_to_py and described the value as a "datetime date".
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request corrects a typo in the docstring of the time_to_py method in _helpers.py, changing "datetime date" to "datetime time" to accurately reflect the method's purpose. There are no review comments, and I have no additional feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small docstring fix in
google-cloud-bigquery.CellDataParser.time_to_pyreturns adatetime.time(via.time()), but its docstring reads "Coerce 'value' to a datetime date", which looks like it was copied from the neighbouringdate_to_py. This just corrects "date" to "time" so the docstring matches what the method actually returns.No behavior change; docstring only.