fix: Use user_verification=discouraged for Reauth WebAuthn challenge. - #17976
Open
joelferrier wants to merge 1 commit into
Open
fix: Use user_verification=discouraged for Reauth WebAuthn challenge.#17976joelferrier wants to merge 1 commit into
joelferrier wants to merge 1 commit into
Conversation
When a fido2 compliant security key is used, and a PIN is configured, the user_verification=preferred value forces PIN authentication. The Reauth API security key challenge is modeled on U2F which does not expose UV requirements. This change removes the PIN prompt requirement for Google Cloud customers with fido2 security keys and session length controls enabled which require security key reauth.
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the WebAuthn user verification parameter from "preferred" to "discouraged" in challenges.py and updates the corresponding test cases in test_challenges.py and test_webauthn_types.py to align with this change. There are no review comments, so I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a fido2 compliant security key is used, and a PIN is configured, the user_verification=preferred value forces PIN authentication.
The Reauth API security key challenge is modeled on U2F which does not expose UV requirements. This change removes the PIN prompt requirement for Google Cloud customers with fido2 security keys and session length controls enabled which require security key reauth.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #17975