Skip to content

impl(pubsub): add options for lease RPCs#4573

Merged
dbolduc merged 1 commit intogoogleapis:mainfrom
dbolduc:fix-pubsub-retry-acks-when-channel-closes-pr-1
Feb 5, 2026
Merged

impl(pubsub): add options for lease RPCs#4573
dbolduc merged 1 commit intogoogleapis:mainfrom
dbolduc:fix-pubsub-retry-acks-when-channel-closes-pr-1

Conversation

@dbolduc
Copy link
Member

@dbolduc dbolduc commented Feb 5, 2026

Part of the work for #4471

Introduce retry options for lease operations that can withstand an hourly connection reset.

Note that the options are not in use yet. The next PR will hook them up to the client.

@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Feb 5, 2026
Comment on lines +253 to +254
#[track_caller]
pub(in super::super) fn verify_policies(o: RequestOptions, grpc_subchannel_count: u32) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to the reviewer:

TIL: #[track_caller] which will display the caller's line number on failed asserts in this function. It does not display the line number that fails in this file, which is why I went for very descriptive error messages.

This is factored out because I will reuse it from leaser.rs in my next PR.

cc: @PhongChuong because you might get a kick out of this.

@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.02%. Comparing base (609a638) to head (a494438).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4573      +/-   ##
==========================================
+ Coverage   95.00%   95.02%   +0.02%     
==========================================
  Files         195      195              
  Lines        7449     7459      +10     
==========================================
+ Hits         7077     7088      +11     
+ Misses        372      371       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dbolduc dbolduc marked this pull request as ready for review February 5, 2026 07:17
@dbolduc dbolduc requested a review from a team as a code owner February 5, 2026 07:17
@dbolduc dbolduc merged commit e0ee977 into googleapis:main Feb 5, 2026
34 checks passed
@dbolduc dbolduc deleted the fix-pubsub-retry-acks-when-channel-closes-pr-1 branch February 5, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the Pub/Sub API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants