impl(pubsub): add options for lease RPCs#4573
Merged
dbolduc merged 1 commit intogoogleapis:mainfrom Feb 5, 2026
Merged
Conversation
dbolduc
commented
Feb 5, 2026
Comment on lines
+253
to
+254
| #[track_caller] | ||
| pub(in super::super) fn verify_policies(o: RequestOptions, grpc_subchannel_count: u32) { |
Member
Author
There was a problem hiding this comment.
Note to the reviewer:
TIL: #[track_caller] which will display the caller's line number on failed asserts in this function. It does not display the line number that fails in this file, which is why I went for very descriptive error messages.
This is factored out because I will reuse it from leaser.rs in my next PR.
cc: @PhongChuong because you might get a kick out of this.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4573 +/- ##
==========================================
+ Coverage 95.00% 95.02% +0.02%
==========================================
Files 195 195
Lines 7449 7459 +10
==========================================
+ Hits 7077 7088 +11
+ Misses 372 371 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
coryan
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the work for #4471
Introduce retry options for lease operations that can withstand an hourly connection reset.
Note that the options are not in use yet. The next PR will hook them up to the client.