test(pubsub): add subscriber sample using into_stream()#4592
test(pubsub): add subscriber sample using into_stream()#4592haphungw wants to merge 4 commits intogoogleapis:mainfrom
subscriber sample using into_stream()#4592Conversation
product-auto-label
bot
added
api: pubsub
haphungw
force-pushed
the
session-sample-update
branch
from
bd2ed97 to
179e079
Compare
haphungw
force-pushed
the
session-sample-update
branch
2 times, most recently
from
95548e1 to
fd1348a
Compare
haphungw
changed the title
quickstart_subscriber sample to use into_stream()subscriber sample using into_stream()
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4592 +/- ##
==========================================
+ Coverage 95.01% 95.02% +0.01%
==========================================
Files 195 195
Lines 7458 7464 +6
==========================================
+ Hits 7086 7093 +7
+ Misses 372 371 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
haphungw
force-pushed
the
session-sample-update
branch
from
fd1348a to
8d6298e
Compare
coryan
left a comment
coryan
left a comment
There was a problem hiding this comment.
If this is blocking some other work, merge and we can iterate. Otherwise it may need to work until Monday, I am about to stop working.
| for name in subscriptions.into_iter() { | ||
| if let Err(e) = cleanup_test_subscription(&subscription_admin, name.clone()).await { | ||
| println!("Error cleaning up test subscription {name}: {e:?}"); | ||
| } |
There was a problem hiding this comment.
I think the ? inside this block will return from the function, skipping the cleanup.
I think we need to move these to a function. Which (incidentally) can be outside the #[cfg(all(test, feature = "run-integration-tests"))] conditional and get better linting and faster feedback loops during development.
dbolduc
added
the
do not merge
We should get #4590 in first, then rebase this PR on top of that one. |
3 participants
For #4574