Skip to content

test(showcase): verify PQC transport with TLS in http and grpc - #6455

Open
suzmue wants to merge 5 commits into
googleapis:mainfrom
suzmue:showcase-tls-pqc
Open

test(showcase): verify PQC transport with TLS in http and grpc#6455
suzmue wants to merge 5 commits into
googleapis:mainfrom
suzmue:showcase-tls-pqc

Conversation

@suzmue

@suzmue suzmue commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Add an integration test target for gapic-showcase running with Auto-TLS and restricted key exchange groups (--tls-groups 0x11ec). This verifies that the HTTP (reqwest) and gRPC (tonic) transports in google-cloud-rust successfully perform post-quantum hybrid key exchange using X25519MLKEM768.

Add an integration test target for gapic-showcase running with Auto-TLS
and restricted key exchange groups (--tls-groups 0x11ec). This verifies
that the HTTP (reqwest) and gRPC (tonic) transports in google-cloud-rust
successfully perform post-quantum hybrid key exchange using
X25519MLKEM768.
@suzmue
suzmue requested a review from a team as a code owner August 19, 2026 02:42
@suzmue
suzmue marked this pull request as draft August 19, 2026 02:42

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces Post-Quantum Cryptography (PQC) transport verification tests to ensure that the SDK's transports support and negotiate hybrid key exchange algorithms (specifically X25519MLKEM768) over TLS 1.3. Feedback on the changes highlights several improvements: failing early if the showcase server fails to start, avoiding unwrap() on path conversions, appending the process ID to the temporary CA certificate filename to prevent race conditions, and addressing the concurrency risks of calling std::env::set_var to set SSL_CERT_FILE globally.

Comment thread tests/showcase/src/pqc.rs
Comment thread tests/showcase/src/pqc.rs Outdated
Comment thread tests/showcase/src/pqc.rs Outdated
Comment thread tests/showcase/src/pqc.rs
@codecov

codecov Bot commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.10%. Comparing base (49b4e5b) to head (33546cc).
⚠️ Report is 24 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6455   +/-   ##
=======================================
  Coverage   96.10%   96.10%           
=======================================
  Files         289      289           
  Lines       77597    77597           
=======================================
  Hits        74578    74578           
  Misses       3019     3019           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

suzmue added 3 commits August 19, 2026 02:57
Update the PQC integration test to:
- Use a unique CA certificate filename including the process ID to
  prevent temp file collisions across test runs.
- Avoid unwrap() on path to string conversions by safely propagating
  errors.
- Fail fast and return an explicit error immediately if the server
  fails readiness checks.
@suzmue suzmue changed the title test(showcase): verify PQC X25519MLKEM768 transport with TLS test(showcase): verify PQC transport with TLS in http and grpc Aug 19, 2026
@suzmue
suzmue marked this pull request as ready for review August 19, 2026 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant