-
Notifications
You must be signed in to change notification settings - Fork 141
feat(storage): global custom header configuration #6458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
a6accab
feat(storage): global custom header configuration
xlai20 9e2bb5a
test(gax-internal): harmonize unit test names for make_headers
xlai20 3836f40
chore: restore Cargo.lock to match main
xlai20 8198dfd
fix(gax-internal): preserve multi-valued headers during custom header…
xlai20 9335e2e
refactor(gax-internal): share sanitize_custom_headers and header cons…
xlai20 f371622
docs(gax-internal): document cross-transport test coverage in sanitiz…
xlai20 d627a17
docs(gax-internal): document global and request-level custom headers …
xlai20 7145ed6
chore(gax-internal): relocate Extensions re-export above ClientConfig…
xlai20 8ae4118
docs(storage): document Repeated Headers in ClientBuilder::with_custo…
xlai20 5f56bc1
docs(storage): improve flow of with_custom_header doc comment in Clie…
xlai20 ec340dd
docs(storage): fix typo in with_custom_header doc comment
xlai20 b3c9bce
Merge remote-tracking branch 'upstream/main' into custom-headers-global
xlai20 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| // Copyright 2026 Google LLC | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // https://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| use http::header::{HeaderMap, HeaderName}; | ||
|
|
||
| pub(crate) const X_GOOG_USER_PROJECT: HeaderName = HeaderName::from_static("x-goog-user-project"); | ||
| pub(crate) const X_GOOG_API_KEY: HeaderName = HeaderName::from_static("x-goog-api-key"); | ||
| pub(crate) const X_GOOG_REQUEST_PARAMS: HeaderName = | ||
| HeaderName::from_static("x-goog-request-params"); | ||
| pub(crate) const X_GOOG_API_CLIENT: HeaderName = HeaderName::from_static("x-goog-api-client"); | ||
|
|
||
| /// Strips all reserved system and telemetry keys from the provided custom headers map. | ||
| /// | ||
| /// This is a shared utility across both HTTP and gRPC transport layers, with end-to-end | ||
| /// sanitization behavior covered by transport test suites on both sides. | ||
| pub(crate) fn sanitize_custom_headers(headers: &mut HeaderMap) { | ||
| for key in [ | ||
| http::header::USER_AGENT, | ||
| http::header::AUTHORIZATION, | ||
| X_GOOG_API_KEY, | ||
| X_GOOG_USER_PROJECT, | ||
| X_GOOG_REQUEST_PARAMS, | ||
| X_GOOG_API_CLIENT, | ||
| ] { | ||
| headers.remove(key); | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.