Skip to content

refactor(gax): consolidate grpc-rust test mocks and fixtures - #6481

Closed
joshuatants wants to merge 1 commit into
googleapis:grpc_rustfrom
joshuatants:grpc_rust_refactor_test_helpers
Closed

refactor(gax): consolidate grpc-rust test mocks and fixtures#6481
joshuatants wants to merge 1 commit into
googleapis:grpc_rustfrom
joshuatants:grpc_rust_refactor_test_helpers

Conversation

@joshuatants

Copy link
Copy Markdown
Contributor

For #5991

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the grpc_rust unit tests by consolidating duplicate mock streams, test messages, and helper structures (such as MockSendStream, MockRecvStream, and MockInvoker) into a new shared testing module. Feedback suggests further improving these shared test helpers by adding getter methods to MockSendStream and MockInvoker to allow direct inspection of captured messages, options, and headers, thereby reducing boilerplate in the test suites.

Comment thread src/gax-internal/src/grpc/grpc_rust/testing.rs Outdated
Comment thread src/gax-internal/src/grpc/grpc_rust/testing.rs Outdated
@codecov

codecov Bot commented Aug 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.13924% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.39%. Comparing base (1506fc1) to head (d4190af).

Files with missing lines Patch % Lines
src/gax-internal/src/grpc/grpc_rust/testing.rs 84.44% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           grpc_rust    #6481   +/-   ##
==========================================
  Coverage      96.39%   96.39%           
==========================================
  Files            302      303    +1     
  Lines          85747    85734   -13     
==========================================
- Hits           82656    82647    -9     
+ Misses          3091     3087    -4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joshuatants
joshuatants force-pushed the grpc_rust_refactor_test_helpers branch 3 times, most recently from 513649f to e0e2671 Compare August 20, 2026 23:38
@joshuatants
joshuatants force-pushed the grpc_rust_refactor_test_helpers branch from e0e2671 to d4190af Compare August 20, 2026 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant