refactor(gax): consolidate grpc-rust test mocks and fixtures - #6481
refactor(gax): consolidate grpc-rust test mocks and fixtures#6481joshuatants wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the grpc_rust unit tests by consolidating duplicate mock streams, test messages, and helper structures (such as MockSendStream, MockRecvStream, and MockInvoker) into a new shared testing module. Feedback suggests further improving these shared test helpers by adding getter methods to MockSendStream and MockInvoker to allow direct inspection of captured messages, options, and headers, thereby reducing boilerplate in the test suites.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## grpc_rust #6481 +/- ##
==========================================
Coverage 96.39% 96.39%
==========================================
Files 302 303 +1
Lines 85747 85734 -13
==========================================
- Hits 82656 82647 -9
+ Misses 3091 3087 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
513649f to
e0e2671
Compare
e0e2671 to
d4190af
Compare
For #5991