Open
Conversation
Adds the `isType` expression, and the `Type` enum, which contains all the types that the Firestore backend can generate. Question: The `DocumentChange` class defines a `Type` enum that represents all snapshot diff types. Is it okay to have these two enum types in the SDK?
product-auto-label
bot
added
size: m
yvonnep165
reviewed
Mar 11, 2026
samples/preview-snippets/src/main/java/com/example/firestore/PipelineSnippets.java
Outdated
Show resolved
Hide resolved
yvonnep165
approved these changes
Mar 11, 2026
Contributor
yvonnep165
left a comment
yvonnep165
left a comment
There was a problem hiding this comment.
For the Type enum question, I would say ok to have the two enum types in the SDK. But I'm not 100% confident to say so. Will rely on Mila's opinion. Everything else looks good to me!
Contributor
Good question, my gut says no, cause it is not a good practice to have 2 APIs of the same name and expect users to use prefix to differentiate them. Please use a more descriptive naming for this, maybe like |
milaGGL
approved these changes
Mar 17, 2026
Contributor
milaGGL
left a comment
milaGGL
left a comment
There was a problem hiding this comment.
LGTM. Good catch on the duplicated enum "Type".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
isTypeexpression, and theTypeenum, which contains all the types that the Firestore backend can generate.Question: The
DocumentChange(DocumentChange.java) class already defines aTypeenum that represents all snapshot diff types. Is it okay to have these two enum types in the SDK? I believe most users would use this type asDocumentChange.Typerather than justType, so there should be no name collisions.