Skip to content

feat!: upgrades action to node24 - #1192

Open
baywet wants to merge 4 commits into
googleapis:mainfrom
baywet:feat/node-24
Open

feat!: upgrades action to node24#1192
baywet wants to merge 4 commits into
googleapis:mainfrom
baywet:feat/node-24

Conversation

@baywet

@baywet baywet commented Apr 6, 2026

Copy link
Copy Markdown

fixes #1162
closes #1188
cc #@chingor13

@ruchernchong

Copy link
Copy Markdown

Hoping this gets merged soon

@Busthomi Busthomi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be great for security update instead of using node 20

Signed-off-by: Vincent Biret <vincentbiret@hotmail.com>

@jcourtois86 jcourtois86 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to get this finally merged as the date for Node JS 20 is coming and was already pushed once by Github from April 26 to June 26

@vsrikrishna

vsrikrishna commented Apr 17, 2026

Copy link
Copy Markdown

+1.
@chingor13 - this has 4 approvals now. Node 20 EOL deadline is approaching. Any blockers on merging this? Can you release, please ;)

Signed-off-by: Vincent Biret <vincentbiret@hotmail.com>
Comment thread .github/workflows/ci.yaml Outdated
Comment thread .github/workflows/ci.yaml Outdated
Co-authored-by: Vincent Biret <vincentbiret@hotmail.com>
Signed-off-by: Vincent Biret <vincentbiret@hotmail.com>
@baywet

baywet commented Apr 22, 2026

Copy link
Copy Markdown
Author

@chingor13 since #1188 was merged, this once should probably just be squashed merged as a ci: cleanup at this stage.

@vsrikrishna

vsrikrishna commented Apr 30, 2026

Copy link
Copy Markdown

@baywet Can you help merge this PR for us? @chingor13 is not responding.

@baywet

baywet commented Apr 30, 2026

Copy link
Copy Markdown
Author

@vsrikrishna I'm not a maintainer, I don't have merge permissions.

@Busthomi

Copy link
Copy Markdown

@baywet @ruchernchong @vsrikrishna @jcourtois86
I think this resolved by this PR now : #1200

@ruchernchong

Copy link
Copy Markdown

@baywet @ruchernchong @vsrikrishna @jcourtois86

I think this resolved by this PR now : #1200

Yup. I am aware of it. Updated my actions too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update action to use node24

6 participants