refactor(o11y): merge SpanTracer and SpanManager#4158
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the observability tracing components by streamlining the integration with OpenTelemetry. It removes an unnecessary abstraction layer, allowing Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request refactors the tracing implementation by removing the custom TraceManager interface and its OpenTelemetryTraceManager implementation. The SpanTracer and SpanTracerFactory classes are updated to directly use OpenTelemetry's Tracer and Span APIs, simplifying the codebase by removing an abstraction layer. Test files have been updated accordingly. A review comment suggests improving code consistency in SpanTracerFactory.java by using String.format for attemptSpanName construction.
gax-java/gax/src/main/java/com/google/api/gax/tracing/SpanTracerFactory.java
Show resolved
Hide resolved
| public SpanTracerFactory(TraceManager traceManager) { | ||
| this(traceManager, ApiTracerContext.empty()); | ||
| public SpanTracerFactory(OpenTelemetry openTelemetry) { | ||
| this(openTelemetry.getTracer("gax-java"), ApiTracerContext.empty()); |
There was a problem hiding this comment.
Maybe not part of this PR, we want to create a tracer with artifact name and version.
gax-java/gax/src/main/java/com/google/api/gax/tracing/SpanTracerFactory.java
Outdated
Show resolved
Hide resolved
|
|
||
| SpanTracer spanTracer = new SpanTracer(traceManager, this.apiTracerContext, attemptSpanName); | ||
| return spanTracer; | ||
| return new SpanTracer(tracer, this.apiTracerContext, attemptSpanName); |
There was a problem hiding this comment.
Not part of this PR, I think we should reconsider the need of overriding newTracer(ApiTracer parent, SpanName spanName, OperationType operationType) in all factories. Since we don't have all the info in this scenario, I think we should just return a no-op tracer.
|
|
2 participants
No description provided.