Repository navigation
[glyphs-reader] Dump v2/v3 test output to temp_dir - #2231
Merged
Merged
Conversation
The v2-vs-v3 tests write a debug dump of each parsed font to a hardcoded /tmp path, which fails outright when the sandbox only allows TMPDIR. The names were fixed too, so parallel tests clobbered each other's dumps. With this patch we write to temp_dir under the fixture's name.
anthrotype
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the motivation of this patch is to stop agents from investigating test failures that result from their sandbox not letting them write directly to /tmp
The v2-vs-v3 tests write a debug dump of each parsed font to a hardcoded /tmp path, which fails outright when the sandbox only allows TMPDIR. The names were fixed too, so parallel tests clobbered each other's dumps.
With this patch we write to temp_dir under the fixture's name.