Repository navigation
Conversation
When a feature block names the same script and language twice, the second statement is a no-op in fea-rs: only the first decides which default lookups the language gets. feaLib re-adds (or with exclude_dflt removes) them on each repeat since fonttools#4189, and makeotf rejects some repeats, so the same source can compile differently. We keep our behaviour, but now warn at the repeated statement. It is our opinion that such statements are almost always user mistakes, and that feaLib should never have accepted them.
cmyr
force-pushed
the
fea-rs-warn-repeated-language
branch
from
October 9, 2026 17:21
d410c73 to
d977c3f
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a feature block names the same script and language twice, the second statement is a no-op in fea-rs: only the first decides which default lookups the language gets. feaLib re-adds (or with exclude_dflt removes) them on each repeat since fonttools#4189, and makeotf rejects some repeats, so the same source can compile differently.
We keep our behaviour, but now warn at the repeated statement. It is our opinion that such statements are almost always user mistakes, and that feaLib should never have accepted them.