Repository navigation
[ir] Truncate upem * 1.2 in the typo line gap fallback - #2235
Merged
Merged
Conversation
ufo2ft takes int(upem * 1.2) before subtracting the ascender and descender; we kept the fraction, so with e.g. upem 1024 our line gap, hhea ascent and win ascent came out one unit higher than fontmake's.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ufo2ft takes int(upem * 1.2) before subtracting the ascender and descender; we kept the fraction, so with e.g. upem 1024 our line gap, hhea ascent and win ascent came out one unit higher than fontmake's.
This bug is unlikely in real sources, which don't hit the fallback path; but it has occurred in some test sources and the fix is cheap. 🤷