Repository navigation
builder: default Glyphs 2 axes in _vf_filename - #1232
Merged
Merged
Conversation
Since _vf_filename reads axis tags from the raw plist, a Glyphs 2 source without an "Axes" custom parameter raises StopIteration while building the recipe. glyphsLib gives such a font the default Weight and Width axes, so with this patch we fall back to those, as 0.9.93 did. This broke 15 targets on fontc's crater that built with 0.9.93, such as Comfortaa and Eczar.
anthrotype
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since _vf_filename reads axis tags from the raw plist, a Glyphs 2 source without an "Axes" custom parameter raises StopIteration while building the recipe. glyphsLib gives such a font the default Weight and Width axes, so with this patch we fall back to those, as 0.9.93 did.
This unbreaks 15 targets on crater.