Avoid calling UpdateVersionedAssetsOnUpdate with each Play in Editor.#587
Open
ohbibi-bhallion wants to merge 1 commit intogooglesamples:masterfrom
Open
Avoid calling UpdateVersionedAssetsOnUpdate with each Play in Editor.#587ohbibi-bhallion wants to merge 1 commit intogooglesamples:masterfrom
ohbibi-bhallion wants to merge 1 commit intogooglesamples:masterfrom
Conversation
…started in editor
|
Please please please accept this pull request. It is completely unacceptable that the resolver makes iterating projects slower. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid unecessary computation of manifest each time the play mode is started in editor.
This computation takes multiple seconds each time we press play on many projects.
This computation is already made with each asset refresh.
Please note that this was already made on the firebase-unity-sdk equivalent few years ago:
GenerateXmlFromGoogleServicesJsonhttps://github.com/firebase/firebase-unity-sdk/blob/778a4841ac67616b2bd88a6e6f740a816d75b13b/editor/app/src/GenerateXmlFromGoogleServicesJson.cs#L96