Serve SPA with CDN-friendly caching and add ETag-based caching for API responses#174
Draft
Serve SPA with CDN-friendly caching and add ETag-based caching for API responses#174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
304 Not Modifiedwhen appropriate.Description
make_spa_response()which servesindex.htmlwithCache-Control: public, max-age=0, s-maxage=60, stale-while-revalidate=30for CDN-friendly caching.make_api_cached_response(payload)which computes a SHA256 ETag for the JSON payload, returns304whenIf-None-Matchmatches, and setsETag,Cache-Control, andVaryheaders.app.send_static_file("index.html")calls in"/","/login","/privacy", and the 404 handler withmake_spa_response()."/api/trending"and"/api/hackernews"to usemake_api_cached_response()instead of manually creating responses.Testing
Codex Task