Reject blank engine/verifier version at construction (D-8.4, D-9.1) - #2
Merged
Conversation
version is now required and validated non-empty on OCROutput, since an all-blank batch previously collapsed to one (model_name, version) pair and passed aggregate()'s mixed-version check silently — defeating rule #9. Extends the same guard to the verifier arm's identity in run_harness/aggregate, and adds version_source to Runner so the contract test can cross-check each registered runner's version against the real library's __version__ instead of trusting a hand-typed value. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
version is now required and validated non-empty on OCROutput, since an all-blank batch previously collapsed to one (model_name, version) pair and passed aggregate()'s mixed-version check silently — defeating rule #9. Extends the same guard to the verifier arm's identity in run_harness/aggregate, and adds version_source to Runner so the contract test can cross-check each registered runner's version against the real library's version instead of trusting a hand-typed value.