feat: Add lazy mode argument to pyroscope.ebpf #4824
Merged
+35
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
clayton-cornell
added
the
type/docs
korniltsev-grafanista
approved these changes
Nov 27, 2025
clayton-cornell
approved these changes
Nov 28, 2025
Contributor
Author
|
Hi @clayton-cornell , resolved conflict on changelog |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This pr is for #3952, the goal here is only to defer eBPF profiler startup until there are actual targets to profile, I haven't implemented any stop/start mechanism depending on weather or not there are still targets as it might not be necessary yet, this could be implemented maybe in a future PR.
Which issue(s) this PR fixes
This PR fix the unnecessary usage of resource when alloy is deployed as a daemonset and doesn't necessarily have targets to profile
Notes to the Reviewer
To avoid the update args logic to be redundant I moved it into one function
PR Checklist