feat(prometheus): support created timestamp zero ingestion #4889
+198
−64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
💻 Deploy preview available (feat(prometheus): support created timestamp zero ingestion): |
x1unix
force-pushed
the
x1unix/feat/support-ct-zero
branch
2 times, most recently
from
85414b6 to
4afbc8f
Compare
docs/sources/reference/components/prometheus/prometheus.scrape.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/prometheus/prometheus.scrape.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/prometheus/prometheus.scrape.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/prometheus/prometheus.scrape.md
Outdated
Show resolved
Hide resolved
Apply suggestions from Clayton Co-authored-by: Clayton Cornell <[email protected]>
x1unix
force-pushed
the
x1unix/feat/support-ct-zero
branch
from
e1bbcb0 to
219f9dd
Compare
clayton-cornell
added
the
type/docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Which issue(s) this PR fixes
This PR adds
scrape_created_timestamp_zero_ingestionparameter to Alloy config forprometheus.scrapecomponent.See upstream Prometheus proposal for context.
Note
This option is not supported in YAML config as prom's
ScrapeConfigdoesn't expose such option.Upstream PR plans to expose this feature as a command-line feature flag.
Fixes #4045
Notes to the Reviewer
CC @dehaansa @clayton-cornell
PR Checklist