feat(otelcol.receiver): add awss3 receiver #4928
Conversation
x1unix
force-pushed
the
x1unix/feat/s3-receiver
branch
from
8a81d02 to
6cf4c82
Compare
🔍 Dependency ReviewNo existing dependencies were upgraded in go.mod. Only net-new indirect dependencies were added, so there are no version-to-version upgrade implications to analyze. NotesThe following are net-new indirect dependencies introduced by this PR and are not assessed per the rules (no existing dependency versions were changed):
These were added to support a new experimental component (otelcol.receiver.awss3). |
|
💻 Deploy preview available (feat(otelcol.receiver): add awss3 receiver): |
kalleep
left a comment
kalleep
left a comment
There was a problem hiding this comment.
Nice work, left a few comments
| // Defaults filled by upstream OTel receiver in a factory. | ||
| } | ||
|
|
||
| func (args Arguments) receiverConfig() *awss3receiver.Config { |
There was a problem hiding this comment.
This can all me moved into Convert and we can call it from validate
| // SetToDefault implements syntax.Defaulter. | ||
| func (*Arguments) SetToDefault() { | ||
| // Defaults filled by upstream OTel receiver in a factory. | ||
| } |
There was a problem hiding this comment.
If we don't set any default values there is no need to have this function.
|
|
||
| // Extensions implements receiver.Arguments. | ||
| func (args Arguments) Extensions() map[otelcomponent.ID]otelcomponent.Component { | ||
| // TODO(x1unix): expose components after Encodings will be exposed |
There was a problem hiding this comment.
could you create a issue for this work and link in the comment?
| "github.com/grafana/alloy/syntax" | ||
| ) | ||
|
|
||
| func TestArguments_UnmarshalAlloy(t *testing.T) { |
There was a problem hiding this comment.
Maybe we should implement default values and extract them from otel factory can be done by calling .NewFactory().CreateDefaultConfig() and map it back to our config.
The reason for it is so that we can have a test here and we would be able to detect braking changes in default config during otel update
2 participants
PR Description
This PR adds
otelcol.receiver.awss3component, which is a wrapper for awss3receiver opentelemetry collector component.CC @clayton-cornell @dehaansa
Which issue(s) this PR fixes
Partially fixes #4800
Notes to the Reviewer
Note
The wrapper doesn't have support for custom encoding extensions.
Support for custom encoding extensions (and extensions themselves) will be done in next PRs.
PR Checklist