helm: default image tag from appVersion #13453
Open
+40
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Niklas Wagner <[email protected]> Signed-off-by: Vladimir Varankin <[email protected]>
Signed-off-by: Vladimir Varankin <[email protected]>
Signed-off-by: Vladimir Varankin <[email protected]>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| {{- $image := $componentSection.image | default dict -}} | ||
| {{- $image = mustMerge $image .ctx.Values.image -}} | ||
| {{ $image.repository }}:{{ $image.tag }} | ||
| {{ $image.repository }}:{{ $image.tag | default .ctx.Chart.AppVersion }} |
There was a problem hiding this comment.
Bug: Image Config Precedence Inverted
The mustMerge call in mimir.imageReference merges component image config with global image config in the wrong order, causing global settings to override component-specific ones. This contradicts the documented precedence where component tags should take priority over global tags. The arguments to mustMerge should be swapped to mustMerge .ctx.Values.image $componentSection.image so component values override global values.
Contributor
Author
There was a problem hiding this comment.
I think, this comment is wrong (we have tests for this behaviour). The Helm's docs say this:
Merge two or more dictionaries into one, giving precedence to the dest dictionary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
As originally suggested in 97c4ae8 the PR updates the Helm chart to default the container image's tag to the value of chart's AppVersion. This will make managing the future releases simpler, because the release manager won't need to bother updating the values.
Note, in the follow-up PR I will update the CI job that updates the weekly releases (ref. to the comment)
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]. If changelog entry is not needed, please add thechangelog-not-neededlabel to the PR.about-versioning.mdupdated with experimental features.Note
Default container image tag to chart AppVersion with override via values; bump appVersion and update docs/changelog.
templates/_helpers.tplmimir.imageReferencenow defaults tag to.Chart.AppVersionwhen unspecified; precedence defined: component tag → globalimage.tag→ chartappVersion.image.tag; add guidance/examples for overriding tags across components; minor comment fixes.appVersiontor368-547a06a0inChart.yamland update README badge.Written by Cursor Bugbot for commit 33f6d12. This will update automatically on new commits. Configure here.