Fix potential hash collisions of traceql StringArray + compare() improvement #5835
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This fixes a potential hash collision of StringArray static MapKey. Similar to #5716 (comment) we need to write a separator between values, so that
"foo","bar"hashes to a different value than"foobar". Also ports the missing clone of attribute buffers to vparquet5, which was causing panics that caused me to come across this potential hash collision.A few other changes:
[]byte(string)which the compiler can optimize in this case to be zero alloc (confirmed with benchmark).Which issue(s) this PR fixes:
Fixes n/a
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]