Fix GetTrace() in tempo-query #5864
Merged
+11
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrading to grpc 1.38.0 broke compatibility with gogoproto.customtype, and the trace_id field in GetTraceRequest of storage.pb.go uses customtype. This issue only occurs when navigating to a trace in Jaeger UI and then hitting refresh (this triggers a GetTrace() request). Searching traces in Jaeger UI and opening them worked fine before this change as well, because this issued a FindTraces() request, which doesn't use a customtype.
andreasgerstmayr
requested review from
carles-grafana,
electron0zero,
ie-pham,
javiermolinar,
joe-elliott,
mapno,
mattdurham,
mdisibio,
ruslan-mikhailov,
stoewer,
yvrhdn and
zalegrala
as code owners
Signed-off-by: Andreas Gerstmayr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Upgrading to grpc 1.38.0 broke compatibility with customtype in the protobuf schema, and the trace_id field in GetTraceRequest of
cmd/tempo-query/jaeger/storage_v1/storage.pb.gouses customtype.This PR updates tempo-query to use
gogocodecas a workaround to getcustomtypesupport.This issue only occurs when navigating to a trace in Jaeger UI and then hitting refresh (this triggers a
GetTrace()request). Searching traces in Jaeger UI and opening them worked fine before this change as well, because this issued aFindTraces()request, which doesn't use a customtype.This was fun to debug. Initially I thought Jaeger changed something in the protobuf schema in a recent version, however
cmd/tempo-query/jaeger/storage_v1/storage.pb.golooks identical to https://github.com/jaegertracing/jaeger/blob/39ef71ed3564c0790c4a564441b492957a56a860/internal/proto-gen/storage_v1/storage.pb.go.After a while I pointed Claude Code to #5487 and it managed to fix it almost immediately. I verified the changes, they make sense and fix the issue.
Which issue(s) this PR fixes:
Fixes #5487
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]