-
Notifications
You must be signed in to change notification settings - Fork 129
feat: bun related docs (@stonega) #1129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- changed bot.ts to index.ts - mention bun at hosting docs
|
🚀 Deployed on https://690dd35ebfa55ee9a3317450--grammy.netlify.app |
|
Should we leave |
|
I have now wasted more time on this than I ever wanted, maybe I'll get back to this in a week or so |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The bottom line of this is still that whatever we do with the tutorial, the output must look exactly like
website/site/docs/guide/getting-started.md
Lines 56 to 66 in 53c1efe
| Create a new empty text file, e.g. called `bot.ts`. | |
| Your folder structure should now look like this: | |
| ```asciiart:no-line-numbers | |
| . | |
| ├── bot.ts | |
| ├── node_modules/ | |
| ├── package.json | |
| ├── package-lock.json | |
| └── tsconfig.json | |
| ``` |
|
I'll get into this page in more detail tomorrow |
|
Remember to merge |
|
Scratch that, it already happened |
|
I even did it myself *facepalm* |
KnorpelSenf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still does not create the same TS config as tsc --init if I understand this correctly
|
Unfortunately we can't fix it. We will have to ask the user to change it manually every time. |
|
Yeah but I don't want to go through all the code examples and make sure that they compile even with the non-standard TS config that bun introduces. It can be fixed very easily by running |
Great, I'll take care of that PR |
That's true, what was stopping you? |
Nice |
|
|
||
| You can also send a `Buffer` object, or an iterator that yields `Buffer` objects. | ||
| On Deno, you can send `Blob` objects, too. | ||
| On Deno and Bun you can send `Blob` objects, too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| On Deno and Bun you can send `Blob` objects, too. | |
| On Deno and Bun, you can send `Blob` objects, too. |
Originally PR was created by @stonega, but it looks like he's not going to continue with this PR. So, I think we should mention Bun as a possible way to work with a bot, even though Bun has a large number of issues. Also Bun finally supports conversations plugin and a decent part of Russian language chat users use it for their projects.
I made some changes and added Bun mentions to the hosting files documentation