fix: raised card design #2526
Open
fix: raised card design #2526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview is ready. |
Contributor
|
🎭 Component Tests Report is ready. |
|
The fixed shadow looks great! From the design perspective – regarding the stroke, I'd challenge that decoration. When 2 types of raised cards are displayed in one interface, the stroke doesn't seem to properly communicate the card's interactivity, but creates more visual chaos. So in my opinion we can get rid of the steoke both in Figma and implemented component. @korvin89 wdyt? |
amje
requested changes
Dec 23, 2025
| } | ||
| } | ||
|
|
||
| @at-root &#{$block}_size_l { |
Contributor
There was a problem hiding this comment.
Let's also move --_--box-shadow: 0px 1px 5px var(--g-color-sfx-shadow); declaration from above under @at-root &#{$block}_size_m section here to be symmetrical with &_type_container styles below
tungulin
force-pushed
the
fix/raised-card-design
branch
from
84dab34 to
86c86c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added border for Card variant raised, fixed shadows for Card variant raised size l. According to the design of Figma