refactor(demo): Convert core to standalone#4309
Open
joannalauu wants to merge 4 commits intodevelopfrom
Open
Conversation
joannalauu
force-pushed
the
refactor/demo/core
branch
from
f213360 to
24f4e8f
Compare
xelaint
requested changes
Jan 28, 2026
joannalauu
force-pushed
the
refactor/demo/core
branch
2 times, most recently
from
bb7680e to
04822d5
Compare
joannalauu
force-pushed
the
refactor/demo/core
branch
4 times, most recently
from
71e8584 to
8681612
Compare
joannalauu
force-pushed
the
refactor/demo/core
branch
from
8681612 to
8f27df7
Compare
Member
|
@joannalauu needs a rebase |
joannalauu
force-pushed
the
refactor/demo/core
branch
from
8f27df7 to
e97ca96
Compare
damienwebdev
reviewed
Mar 3, 2026
| component: TemplateComponent, | ||
| providers: [ | ||
| provideDemoSidebarState(), | ||
| provideDemoImageGalleryState(), |
Member
There was a problem hiding this comment.
I'm not sure that this state provider belongs here. I think this is only use on the product page.
damienwebdev
requested changes
Mar 3, 2026
Member
damienwebdev
left a comment
damienwebdev
left a comment
There was a problem hiding this comment.
Only 1 small comment, otherwise, generally LGTM.
joannalauu
force-pushed
the
refactor/demo/core
branch
from
b82f287 to
b462f40
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
Current behavior
Fixes: #
Part of: #3664
New behavior
Core of demo app is now standalone. Modules have been removed.
Breaking change?
Additional context