initial stab at guzzle7 #45
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorrynkovoy
approved these changes
Nov 2, 2021
|
@adlawson @psfpro @sjparkinson ping |
kchigrinov
suggested changes
Nov 2, 2021
src/Exception/RequestException.php
Outdated
| \Throwable $previous = null, | ||
| array $handlerContext = [], | ||
| BodySummarizerInterface $bodySummarizer = null | ||
| ): self { |
There was a problem hiding this comment.
Return type from this class won't be compatible with extended HttpRequestException class. It'll be compatible only from php version 7.4 and higher. Return type should be HttpRequestException or change requirements for php in composer. You can test it here http://sandbox.onlinephpfunctions.com/code/a437cd577e3930240274bfed9baecb7c75bef7b2
h-bragg
commented
Feb 21, 2022
as per @kchigrinov suggestion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hacky implementation of guzzle7...
looking at #41
if anyone wants to productise this better, feel free!