Skip to content

Conversation

@mojo2012
Copy link

@mojo2012 mojo2012 commented Feb 20, 2020

So I created another PR for my formatter changes.

#941

@eric-milles
Copy link
Member

eric-milles commented Feb 20, 2020

A couple notes to start with:

  1. When you edit a source in org.codehaus.groovyXX, you will likely need to make changes to the same source in the other groovy version bundles.
  2. Have you run these changes on a larger codebase to see if they cause any problems for less common source constructs? The tests are often very simple and I'm not sure of the overall coverage of the formatter tests specifically.
  3. Are any of these formatter settings configurable? The original issue mentions the Java formatter settings. If possible, it would be best to support the same preferences so you can get a similar result for Java and Groovy files.
  4. Is it possible to divide these changes into some smaller groups so we can review and merge in smaller increments?

@eric-milles eric-milles force-pushed the master branch 4 times, most recently from 95284b0 to c7dc75b Compare April 9, 2020 19:53
@eric-milles eric-milles force-pushed the master branch 4 times, most recently from 98c958a to fec194b Compare October 12, 2020 01:50
@eric-milles eric-milles force-pushed the master branch 5 times, most recently from 18c52d7 to a808029 Compare October 21, 2020 17:42
@eric-milles eric-milles force-pushed the master branch 2 times, most recently from d21f3fa to 41556b2 Compare November 1, 2021 18:53
@eric-milles eric-milles force-pushed the master branch 3 times, most recently from d9bd13d to f849ff3 Compare December 11, 2021 05:06
@eric-milles eric-milles force-pushed the master branch 2 times, most recently from ca06efa to f3616f0 Compare November 20, 2022 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants