Skip to content

Conversation

@easwars
Copy link
Contributor

@easwars easwars commented Nov 12, 2025

This is an initial cleanup before the actual work required for #8516

The way the init timeout is currently overridden in existing tests is unnecessary complicated and hard to read. This simplifies things and ensures that the previous pattern is not followed when new tests are written.

RELEASE NOTES: none

@easwars easwars requested a review from mbissa November 12, 2025 06:24
@easwars easwars added the Area: Testing Includes tests and testing utilities that we have for unit and e2e tests within our repo. label Nov 12, 2025
@easwars easwars added this to the 1.78 Release milestone Nov 12, 2025
@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.24%. Comparing base (e816736) to head (0ee723f).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8704      +/-   ##
==========================================
- Coverage   83.29%   83.24%   -0.05%     
==========================================
  Files         416      416              
  Lines       32267    32267              
==========================================
- Hits        26876    26862      -14     
- Misses       4017     4024       +7     
- Partials     1374     1381       +7     

see 19 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@easwars easwars added Type: Testing and removed Area: Testing Includes tests and testing utilities that we have for unit and e2e tests within our repo. labels Nov 12, 2025
Copy link
Contributor

@mbissa mbissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@easwars easwars merged commit c0de489 into grpc:master Nov 13, 2025
15 of 18 checks passed
@easwars easwars deleted the priority_balancer_test_cleanup branch November 13, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants